Save battery thresholds to flash #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpot51
reviewed
Aug 23, 2024
jackpot51
reviewed
Aug 23, 2024
crawfxrd
commented
Aug 23, 2024
With the use of 256 KiB flash chips, the hard-coded address of 0x1FC00 may no longer be "the last sector". Signed-off-by: Tim Crawford <[email protected]>
jackpot51
previously approved these changes
Nov 22, 2024
|
Writing to flash works. Reading it back does not.
|
Make battery thresholds persistent by saving them in flash space. This allows configuring them after EC reset (system powered-off, unplugged) but before any system firmware or OS policy can be applied. Signed-off-by: Tim Crawford <[email protected]>
jackpot51
approved these changes
Nov 26, 2024
leviport
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make battery thresholds persistent by saving them in flash space. This allows configuring them after EC reset (system powered-off, unplugged) but before any system firmware or OS policy can be applied.
As part of this, the dynamic keymap is moved from the hard-coded address of 0x1FC00 to "the last sector"; Models with 256 KiB flash (
CONFIG_EC_FLASH_SIZE_256K=y) will lose their layout and need to reconfigure it.Test
Check values with:
system76-power charge-thresholdscat /sys/class/power_supply/BAT0/charge_control_{start,end}_threshold